1. torr.samaho
  2. zandronum
  3. Pull requests

Pull requests

#184 Open
Repository
zandronum-sandbox
Branch
default
Repository
zandronum
Branch
default

The client now syncs custom userinfo entries (aka client mod CVARs) with the server and with other players.

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r d29d63675b5a https://bitbucket.org/zandronum/zandronum-sandbox
hg merge d29d63675b5a
hg commit -m 'Merged in zandronum/zandronum-sandbox (pull request #184)'
Author
  1. Teemu Piippo
Reviewers
Description

A few notes:

  • Userinfo is now synced as name&string pairs. Yes this means there's some bandwidth increase involved, but userinfo is not being sent very often (clients get kicked if they do) and I don't know if it can be implemented better without large amounts of cruft and I'm not going there.
  • The "failed to send userinfo" errorcode is now merged with the "userinfo rejected" one. The check for incomplete userinfo is now done in SERVER_GetUserInfo.
  • The CVAR_UNSYNCED_USERINFO flag means that even if the cvar is userinfo, it won't be synced to the server. Otherwise all userinfo is synced. This flag cannot imply CVAR_USERINFO because that would conflict with the copies created into userinfo_t.
  • The USERINFO_* defines are now gone. Instead, sets of FNames are used instead.
  • Account name syncing is now done separately of userinfo. Tying it to userinfo was a mistake on my behalf… I had trouble with the official auth server but I tested it as well as I could locally.
  • Learn about pull requests

Comments (0)