Alignment of color handles and colors

Issue #179 closed
Anastasia Baryshnikova created an issue

Comment from Justin Nelson: Bug 4) The triangles indicating the colors do not align well to the colors displayed in the color scheme window. For me, the arrows are shifted to right (See attached file).

AB: I don't see this bug on my Mac, but I thought I'd put it in here just to see if any of you guys have every noticed it.

Comments (16)

  1. Robert Leach

    I suspect that this might be a similar issue to the one I encountered where when I had added 2 sliders of the same color, the colors got swapped (issue #194). In fact, I just tried to reproduce that issue and I could not make it happen. Either it has been fixed or there is some circumstance leading to the issue that we have not completely captured.

  2. Christopher Keil repo owner

    I am also completely incapable of reproducing... i've worked with the colors for hours over days now and haven't encountered this once. Should we put this on hold? In order to fix it we have to be able to reproduce it somehow.

  3. Robert Leach

    Perhaps we can ask Justin Nelson if he can reproduce it, and if so, how he did it, or better yet, send up a screen recording. This is definitely a case where if we had a debug log and a feedback feature, we could figure out what might be going on. I'll see if I can reproduce in an older jar file.

  4. Robert Leach

    Perhaps it's data specific? If the values in that range are sparse, maybe the position of the handles and the position of the gradient starts differ? I dont know - I'm not as familiar with that code.

  5. Robert Leach

    OK, I was able to reproduce with the alpha01 jar with the small_133x133 data set available on the downloads page. Here's what I did after bringing up the colors dialog:

    1. Select green slider (ok)
    2. Click remove slider (ok)
    3. Click red slider (ok)
    4. Click remove slider (did not remove)
    5. Tried step 4 a second time (fine - must have at least 2 sliders)
    6. Clicked add color (ok)
    7. Selected sky blue, just right of white in top left corner (ok)
    8. Clicked add (ok)
    9. Dragged slider as close to the right of the black slider as possible (ok - value 0.004)
    10. Clicked add color (ok)
    11. Selected sky blue, just right of white in top left corner (ok)
    12. Clicked add (ok - added slider right on top of the other sky blue slider, already selected)
    13. Dragged slider to left (see below)

    The new slider icon was sky blue, but the color beneath it was black.

    I have not tried this in master yet, but I bet this is fixed...

  6. Robert Leach

    Forgot the click on the custom radio button step. Reproduced from memory, so might be slightly off. Hopefully it's enough to reproduce again...

  7. Robert Leach

    Nope, I reproduced it in the current master too, so, assuming this issue and #194 are related, I bet the fix would be the same. I think steps 4 & 5 may be unnecessary. perhaps other steps as well. My laptop battery is about to die, or I would spend time distilling the procedure...

  8. Robert Leach

    Actually, I haven't pulled since yesterday morning. Can you reproduce this in your latest version @TreeView3Dev ?

  9. Robert Leach

    Here's the alpha01 reproduction of the issue. Master from yesterday does the same thing except the radios are a select list...

    color_handles_problem_reproduced.png

  10. Robert Leach

    Here's the closest I could get reproducing this specific issue (with alpha01). Probably not the same conditions however:

    closest_i_could_get2.png

  11. Christopher Keil repo owner

    After hours and hours with the color update I have not encountered this issue at all anymore... So I will change this to resolved. If it reappears, we can reopen the issue of course.

  12. Log in to comment