- changed milestone to Coding Convention Adherence
Compartmentalize and consolidate whizzing labels code in LabelView
There are some large methods in LabelView that need to be broken into specific smaller methods. Some methods do not encapsulate all functionality they claim to have in some use cases and that code needs to be consolidated from other areas into those functions. These usually have to do with math to calculate label offsets and scrolls and such, given various factors such as row/col, right/left justified, and whether or not in label port mode.
Comments (6)
-
reporter -
reporter - marked as major
-
reporter - changed status to resolved
The methods could be organized a bit better, but they are much easier to absorb now and a lot of duplicate code has been eliminated. methods were moved where possible from child classes to parent classes. Long methods were broken up. Functionality that was spread across a few methods has been consolidated.
-
reporter - changed status to closed
Merged to master.
-
reporter - changed component to Coding Convention Adherence
-
reporter - removed milestone
Removing milestone: Coding Convention Adherence (automated comment)
- Log in to comment