-
assigned issue to
Time unspecified for individual document review efforts
USE CASE: WHAT DO YOU WANT TO DO?
Have enough time to perform individual document reviews before a document review meeting and have the pull request contents not change between the individual reviews and the document review meeting.
STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)
- Submit a pull request
- Schedule a document review meeting
- Perform individual reviews
- Developer updates and commits changes to the branch linked to the pull request
- Meeting occurs
CURRENT BEHAVIOR
I don't know if we established whether the content of the PR actually can change after submission, but we haven't resolved formally how to allow changes to occur before the document review meeting.
EXPECTED BEHAVIOR
A pull request remains unchanged between individual review and the meeting. Changes to address issues coming out of a document review should be allowed but be able to proceed, but in such a way that exposes them to an independent review. Changes that come from a document review should be better tracked.
DEVELOPERS ONLY SECTION
SUGGESTED CHANGE (Pseudocode optional)
- Change the SCM process to expressly handle changes between individual review and the meeting
- Change the SCM process to utilize better the pull request system to separate changes that result from a review.
- Change the SCM process to manage tracking of changes resulting from a review (specifying when a new issue is created, when an issue must be addressed before or after merge, or on what branch changes should occur).
- Add a process at the end of the review meeting to communicate what decisions were made.
FILES AFFECTED (where the changes will be implemented) - developers only
- SCMP_TreeView3.doc
- document_review_form.txt
- merge_request_form.txt
- document_review_meeting_guidelines.txt
LEVEL OF EFFORT - developers only
medium
COMMENTS
Comments (5)
-
reporter -
reporter - changed status to resolved
Resolved on branch "issue302...".
-
reporter - changed status to closed
Merged to master.
-
reporter - changed component to Software Engineering
-
reporter - removed milestone
Removing milestone: Software Engineering (automated comment)
- Log in to comment