User load mistakes result in non-functional app
USE CASE: WHAT DO YOU WANT TO DO?
Be able to make a mistake when loading a file and get a second chance to get it to load correctly.
STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)
- Open small_133x133.txt
- Check the "space" delimiter
- Click continue
CURRENT BEHAVIOR
App freezes at the 99% load stage.
EXPECTED BEHAVIOR
Get an error window explaining that the number of columns is inconsistent which one can dismiss and be returned to the load interface where they can adjust the load options.
DEVELOPERS ONLY SECTION
SUGGESTED CHANGE (Pseudocode optional)
Check the consistency in the number of columns in the file and throw up an error window if it's inconsistent. Prevent dismissal of the load window in this instance.
FILES AFFECTED (where the changes will be implemented) - developers only
unknown
LEVEL OF EFFORT - developers only
minor
COMMENTS
Found this issue when testing the jar for PR 62. That jar freezes after the load screen disappears.
Comments (9)
-
repo owner -
reporter I agree that HeaderFinderBox should handle these exceptions, but I think that the load interface should catch the problem with the column count inconsistency before it gets to HeaderFinderBox.
-
I see the below exception too (When I load the data for the first time)
So we need to handle both the exceptions.
-
reporter This would be a great one for you to take @smd_faizan. Do you want to take this one?
-
repo owner @smd_faizan @hepcat72 I would actually wait on this issue due to pull request #62. It heavily affects this portion of the code and isn't merged yet. This should be tested for again after merging which will hopefully be soon after alpha03 release.
I know this error and heavily doubt it will occur after merging pull request #62.
-
reporter -
assigned issue to
I believe this will be addressed by another issue Chris is working on, and in looking for an issue to take, I figured I would mark such issues which are somewhat like duplicates as being worked on. It will make it easier for others to select an issue to take.
-
assigned issue to
-
reporter - changed status to on hold
Putting on hold because there's a likely chance that pull request #62 will resolve this issue. If the exception still occurs after its merge, re-open this issue as new.
-
reporter - changed component to Import/export
-
reporter - removed milestone
Removing milestone: Import/export data (automated comment)
- Log in to comment
The related error is a problem in HeaderFinderBox (search).
The issue itself should be purged and possible exceptions handled.