"First data cell:" in load window does not correspond to the row/col numbers and highlight

[Robert Leach]

USE CASE: WHAT DO YOU WANT TO DO?

Identify the row/col labels

STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)

1. Open small_133x133.txt
2. Adjust the "First data cell" spinners.

CURRENT BEHAVIOR

The "First data cell" settings do not appear to be a setting for the first data cell, but rather appear to be settings for the last label row/col. The first data cell in the file is row 3, column 3. However, the correct values for the spinners are row 2, column 2.

EXPECTED BEHAVIOR

I think the interface works fine. I think that the label for the spinners should just be more accurate to the function of the spinners. Either that or the spinner value should be incremented 1 without changing the correct highlighting. If the spinner display value is changed to be the actual first data cell, the spinner should never be allowed to be 0.

DEVELOPERS ONLY SECTION

SUGGESTED CHANGE (Pseudocode optional)

Change the label to "Last label:"

FILES AFFECTED (where the changes will be implemented) - developers only

unknown

LEVEL OF EFFORT - developers only

trivial

COMMENTS

I understand the intention of this change is to streamline the interface and make it look simpler, but I think right now, it is logically incorrect and might lead someone to set incorrect values. They will think that the spinner values for this test file should be 3 and 3.

[Christopher Keil]

The first data cell number used in the spinner is actually the array index right now (which starts at 0). So in essence it just starts counting at 0 when it really should start counting at 1. Trivial to change and completely overlooked that...

[Robert Leach]

This resolves issue 395. The values in the spinners in the data import interface now reflect the number of row and column containing the first datum.

It highlights the first datum with a blue border. I also fixed a minor issue I discovered where the preview dimensions claimed were inaccurate. I fixed this by creating a public static variable in the preview table class and using it in the string construction.

→ <<cset 94f0ceae6f4b>>

[Robert Leach]

This resolves issue 395. The values in the spinners in the data import interface now reflect the number of row and column containing the first datum.

It highlights the first datum with a blue border. I also fixed a minor issue I discovered where the preview dimensions claimed were inaccurate. I fixed this by creating a public static variable in the preview table class and using it in the string construction.

→ <<cset 94f0ceae6f4b>>

[Robert Leach]

Merged to master.

[Robert Leach]

Removing milestone: Import/export data (automated comment)