Number format in color settings

Issue #410 new
Anastasia Baryshnikova created an issue

USE CASE: WHAT DO YOU WANT TO DO?

Adjust color settings

STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)

  1. Reset preferences
  2. Re-open treeview
  3. Open parsons_boone_2004.txt (a matrix with only 0 and negative values)
  4. Choose View > Colors

CURRENT BEHAVIOR

The right-most color handles shows a very low (but not-zero) value (image attached). When you double click on the handle, the value becomes 0.

Screen Shot 2016-05-16 at 10.17.18 AM.png

EXPECTED BEHAVIOR

The value should be 0 in both cases (unless the user explicitly sets the handle to a custom value or if the value makes sense in the given data range*).

  • i.e. only fix the problem with the automatically generated handle value in this case where it is outside the data range and do not round manually entered values or values whose significant digits can make a color difference when they are incremented or decremented.

DEVELOPERS ONLY SECTION

SUGGESTED CHANGE (Pseudocode optional)

Don't change the saved number of a thumb, but display a rounded number.

Round saved numbers of a thumb only when they are automatically generated/calculated and the colors of the rounded value and the original value are the same.

In the thumb edit dialog, always show the real/calculated/manually-entered values, not the rounded one.

FILES AFFECTED (where the changes will be implemented) - developers only

  • NumBox
  • BoundaryBox
  • ThumbBox

LEVEL OF EFFORT - developers only

medium

COMMENTS

Comments (16)

  1. Robert Leach

    Given other issues with min/max/etc being remembered from a previously open file, I had to perform extra steps to reproduce this issue:

    1. Start a fresh instance of TreeView
    2. Open the attached file (where colors still are set to the previous file's thumb settings)
    3. Set the max thumb to 0

    The resulting displayed value I get is "0E0".

  2. Robert Leach

    Suspending work - likely to conflict with other efforts, but I at least detected where the issue appears to be.

  3. Robert Leach
    • removed responsible

    I know others have looked at this issue, so I will abandon the little changes I've made on a separate branch thus far, as I never really got far with it anyway.

  4. Log in to comment