- changed status to resolved
Reduce minimum number of pull request approvals to 1 reviewer
USE CASE: WHAT DO YOU WANT TO DO?
Resolve pull requests in a timely manner
STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)
- Submit a pull request
- Get an approval response from the required number of reviewers according to the SCMP
CURRENT BEHAVIOR
The SCMP currently requires a minimum of 2 responses (not including the author) to a pull request to approve a merge. Yet of the 3 coders able to approve a pull request, only 2 are active and knowledgeable about the code. Pull requests hence tend to linger awhile.
EXPECTED BEHAVIOR
Since there are only 2 active coders in the project and 1 must be an author, having a requirement of 1 approval seems more efficient.
DEVELOPERS ONLY SECTION
SUGGESTED CHANGE (Pseudocode optional)
Change the SCMP to require only 1 approval response.
FILES AFFECTED (where the changes will be implemented) - developers only
SCMP
LEVEL OF EFFORT - developers only
trivial
COMMENTS
Comments (3)
-
reporter -
reporter - changed component to Software Engineering
-
reporter - removed milestone
Removing milestone: Software Engineering (automated comment)
- Log in to comment
Done.