Skip loading interface after clustering
USE CASE: WHAT DO YOU WANT TO DO?
Eliminate the (redudant) step of confirming the loading parameters after clustering.
STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)
Open any matrix > cluster it.
CURRENT BEHAVIOR
When clustering is complete, a loading interface pops out as if this is a new file being loaded.
EXPECTED BEHAVIOR
Since this file was already loaded and has been just manipulated by Treeview, the loading interface step should be omitted.
DEVELOPERS ONLY SECTION
SUGGESTED CHANGE (Pseudocode optional)
e.g. Add a color selection class
FILES AFFECTED (where the changes will be implemented) - developers only
e.g. selectColor.java & settingsPanel.java
LEVEL OF EFFORT - developers only
trivial/minor/medium/major/overhaul (choose one)
COMMENTS
Comments (7)
-
repo owner -
Yes, this is fixed in PR62 (is there a duplicate BB issue on this?). The review of that PR has completed, but there are 40+ issues (most minor) that simply take some time to address. Plus, we should have a meeting to go over the major issues that were brought up (to avoid the situation such as we encountered with the export preview where it took awhile without a meeting see eye to eye on the nature of the issues).
I think that the main issue with the PR was adding an explicit import file menu option in case a user makes a mistake during the first load of a file.
I don't think (if I recall correctly) that any of the issues are particularly arduous to address - there are just a lot of them (it was a large branch). I do acknowledge that we agreed to put this off until after release, but I also see value in reconsidering that plan, so I propose 1 of 2 possible avenues here:
- Release alpha03 without it, we have a doc review meeting (as per standard procedure), Chris works on PR62 issues, and we issue an incremental update
- I (Rob) branch off of the PR62 branch and Chris and I divvy up the issues and we wrap it up before alpha03 release.
I think that option 2 runs the risk of introducing bugs in an otherwise mature master branch and would thus vote for option 1.
-
reporter I suggest we go with option 1 (address this after alpha3 release).
-
- changed status to resolved
Resolved in pull request #62.
-
- changed component to Clustering
-
- removed milestone
Removing milestone: Clustering (automated comment)
-
- changed version to beta2
- Log in to comment
I know this is annoying but it has been taken care of in pull request #62 and was actually really involved to implement. Reviewing and updating that PR is quite a process and we originally set out to do it post alpha03 - @hepcat72 what do you think?