Eliminate need for onBorder method in DragGridPanel

Issue #473 new
Robert Leach created an issue

USE CASE: WHAT DO YOU WANT TO DO?

Reduce code if funtionality can be fully retained.

STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)

n/a

CURRENT BEHAVIOR

onBorder is called from various mouse methods.

EXPECTED BEHAVIOR

Add a MouseAdapter to the Border object and set a boolean upon Border.mouseEntered() and Border.mouseExited().

DEVELOPERS ONLY SECTION

SUGGESTED CHANGE (Pseudocode optional)

See expected behavior.

FILES AFFECTED (where the changes will be implemented) - developers only

DragGridPanel

LEVEL OF EFFORT - developers only

minor

COMMENTS

The Border of a JPanel (and hence a DragGridPanel) is an object which can be queried. Is this method still needed or could there be a simple check/ update by adding a MouseAdapter to the Border object and setting a boolean upon Border.mouseEntered() and Border.mouseExited(). It's always good to reduce code if funtionality can be fully retained.

See pull request #109, Chris's issue number 10 during the review to see the origination of this issue.

Comments (0)

  1. Log in to comment