Make the call to setCalculatedDimensions automatic

Issue #527 new
Robert Leach created an issue

USE CASE: WHAT DO YOU WANT TO DO?

Simplify the class interface for determining all export dimensions.

STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)

The desired interface is:

  1. Set the choices such as label inclusion, trees, aspect, etc.
  2. Call getXDim, getYDim, etc. without needing to call setCalculatedDimensions.

CURRENT BEHAVIOR

After changing any options, a call to setCalculatedDimensions is necessary to get the dimensions that reflect the set options.

EXPECTED BEHAVIOR

Calls to setCalculatedDimensions are automatic.

DEVELOPERS ONLY SECTION

SUGGESTED CHANGE (Pseudocode optional)

Put a call to setCalculatedDimensions everywhere where a dimension calculated/changed by setCalculatedDimensions is gotten (i.e. all the getters for numbers touched by setCalculatedDimensions).

FILES AFFECTED (where the changes will be implemented) - developers only

  • ExportHandler
  • Anywhere where setCalculatedDimensions is called (remove)

LEVEL OF EFFORT - developers only

minor

COMMENTS

Found during review of pull request #133. Issue 3 in that PR.

Comments (0)

  1. Log in to comment