Sluggishness due to data ticker zoom calculations

Issue #560 closed
Robert Leach created an issue

USE CASE: WHAT DO YOU WANT TO DO?

I want to have snappy/fast interactions with the interactive matrix.

STEPS TO REPRODUCE AN ISSUE (OR TRIGGER A NEW FEATURE)

  1. Open the large_6kx6k.txt file
  2. Click the "+" button 4 times in rapid succession
  3. Scroll up/down/left/right

CURRENT BEHAVIOR

The behavior of the interface as of commit 3b429ec to master on 1/5/2017, is sluggish for the first few "+" button clicks and scrolling at mostly zoomed-out levels.

EXPECTED BEHAVIOR

The behavior in master before commit 3b429ec on 1/5/2017 was snappy and fast for all operations and zoom levels for the max supported file size.

DEVELOPERS ONLY SECTION

SUGGESTED CHANGE (Pseudocode optional)

This commit, which caused the sluggish behavior is very likely due to the calculation of the average tile value of the zoomed area, which is calculated via a nested loop structure.

Probably the best way to handle this issue is to start a timer whenever a navigation operation is performed on the matrix (scrolling & zooming) via any of their triggering methods.

ALSO - calculation of the average does not need to happen until the cursor has hovered off the matrix. When the cursor is hovered over the matrix, the only value that the data ticker must display is the current hovered tile's value.

FILES AFFECTED (where the changes will be implemented) - developers only

Every file from the commit:

  • DendroController.java
  • DataMatrix.java
  • DataTicker.java
  • IMVMouseAdapter.java
  • MatrixViewController.java
  • MatrixViewController.java.orig
  • ModelView.java
  • model/ReorderedDataModel.java
  • model/TVModel.java
  • plugin/dendroview/DendroView.java
  • plugin/dendroview/ExportPanel.java.orig
  • plugin/dendroview/LabelView.java
  • plugin/dendroview/LabelView.java.orig
  • plugin/dendroview/TRView.java

LEVEL OF EFFORT - developers only

medium

COMMENTS

Related to issue #553 (mouse wheel slow) - discovered this issue while working on #553.

The commit in question was merged to master from:

smd_faizan/treeview3/issue442 (pull request #108)

Issue442-DataTicker value when matrix is Zoomed

Comments (3)

  1. Log in to comment