Continually re-opening search window

[Robert Leach]

Not certain what caused this, but I had selected a tree node in both the rows and columns and clicked the search button. I don't remember if I had performed a search or not, but upon closing the search window, a new search window opened right back up. Every time I closed the new window a new one would open to replace it in the center of the screen. I tried moving one of the search windows before closing it to make sure I wasn't just seeing it flash and not go away: the window went away and a new window showed up in the center again.

[Robert Leach]

I captured this behavior is a long screen-recorded debugging session. You can download the 500MB file here:

http://gen-rlimac.princeton.edu/~rleach/TREEVIEWBUGS/multiple_bugs/multiple_bugs.mov

The event is at time index 11:00-11:11 anf there's another such event later on, but I don;t have the time index of that.

[Robert Leach]

I think I figured out how to make this happen. Each time you cluster (I tested using hierarchical), it adds 2 more search windows that show up after the original. If you cluster once, 2 extra search windows will show up when you close the first. If you cluster twice, 4 extras will open. 3 times -> 6 extras, etc..

[Robert Leach]

Boy, I feel like I'm getting in over my java head here, but I figured out a little more. When you run clustering, it ends up adding more search button listeners without removing the old listeners. I put a console debug message in "addSearchButtonListener" and it indeed prints twice after clustering. From what I read, it seems like it's suggested that listeners are removed before adding a new one. I'll see if I can figure out how to do that.

[Robert Leach]

Added a loop to remove previously added action listeners when adding a search button listener.

[Robert Leach]

Fully resolved issue 9 from pull request #133 - Export situations that have no possible valid export given size now prevent the export dialog from popping up.

Also, if a document format export is possible, but image export is not, the format select list is adjusted to not provide image export options. Note, it was not possible using JComboBox to disable the image options, but still leave them visible.

Switching formats also triggers updates of the other dialog elements.

→ <<cset adf1fc057e9a>>

[Robert Leach]

BB changed the status incorrectly based on a PR comment.