- edited description
- removed milestone
Postprocess should handle all assemblies and create instance should use FullName
Issue #47
resolved
- In Postprocess, the original code use GetExecutingAssembly(), but it's possible there are other assemblies which implement IPostprocess interface to customize the logic. I would recommend to use AppDomain.CurrentDomain.GetAssemblies() instead.
- CreateInstance should use t.FullName since it's possible that "t" has namespace, etc.
Comments (5)
-
reporter -
@idlestudios thank you for reporting this. There are a bunch of areas that tool access assembly info - I will fix this issue.
Meanwhile, I would like to make sure that I cover real use case scenario that requires this change. Would you be kind to provide me in which case you bumped into?
I imagine that this can be an issue if you have code implement interface in pre-built dll - anything else?
-
- changed milestone to 1.3
-
reporter Correct, my unity modules are pre-build dlls and would like to extend asset build process based on asset bundle graph tool.
-
- changed status to resolved
Solved this issue with 39a47c3 (in dev branch) Please confirm if it is fixed in your environment.
- Log in to comment