Issue #3 new

VER=$(echo $VERSION|sed 's/-/_/') #this fixes - in version

stretchedthin
created an issue

SlackBuilds have the line... VER=$(echo $VERSION|sed 's/-/_/') #this fixes - in version but the line that should implement it... makepkg -l y -c n $RELEASEDIR/$NAME-$VERSION-$ARCH-$BUILD.txz

still refers to the original $VERSION variable. suggest changing this to the $VER, variable so that any hyphens are automatically removed from version number.

Comments (3)

  1. Rodrigo Bistolfi

    When the SlackBuild template was made this topic came out. At that moment the decission was to leave this task to the packager. Maybe we can have this discussion again.

  2. stretchedthin reporter

    (Reply via ken2...@gmail.com):

    That seems counter intuitive. Why would leaving the dash in a version number be an acceptable option.

    I think the very purpose of this function is to compensate for possibility of human error.

  3. Rodrigo Bistolfi

    Why would leaving the dash in a version number be an acceptable option.

    Leaving the dash is not an option, but changing the sed line is. Sometimes is hard to anticipate all the cases and this could be one of those. We are evaluating replacing "" also and using $VER for makepkg. The problem here is that regular expressions are error prone, and its hard to make them work for every possible input.

    I think the very purpose of this function is to compensate for possibility of human error.

    Remember that the goal of sbbuiler is to produce a starting point for the packager and does not replace the understanding of the SlackBuild and the issues related to packaging, as described in the packaging gide: http://vectorlinux.osuosl.org/docs/packaging/

  4. Log in to comment