Simone Marzola avatar Simone Marzola committed 3c94e68

catch IntegrityErrors in votes and rollback the transaction

Comments (0)

Files changed (1)

tgcomments/controllers/root.py

 
 def back_to_referer(*args, **kw):
     if not kw.get('success'):
-        flash('Failed to post comment', 'error')
+        flash(_('Failed to post comment'), 'error')
     if request.referer is not None:
         raise redirect(request.referer)
     raise redirect(request.host_url)
 
         try:
             DBSession.flush()
-            transaction.commit()
         except IntegrityError:
-            return back_to_referer(success=False)
+            transaction.doom()
+            flash(_('Already voted this comment'), 'warning')
+            return back_to_referer(success=True)
 
         flash(_('Thanks for your vote!'))
         return back_to_referer(success=True)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.