Dependency on RoBO
Issue #5
closed
The main code base does not include any dependency on RoBO any more, but the unit tests do, as well as a commit in the automl branch. Two questions arise:
- Do we want to keep the dependency on RoBO in:
- smac.test.test_local_search
- smac.test.test_smbo
- test_files/example_branin.py
- Should https://bitbucket.org/aadfreiburg/smac3/commits/36706bef6b093c43b82f3d5db2b665e0798e8ade?at=development still be merged or can I actually delete the branch automl?
Comments (8)
-
-
reporter @aaron_klein can you please comment on that?
-
Tobi copied everything that we used from RoBO so we do not have any dependencies to it anymore
-
reporter I can still see RoBO in the unit tests in the locations mentioned above.
-
Hi,
how to proceed here? Can we simply remove the unit test with problematic imports for the time being?
Cheers, Marius
-
reporter @aaron_klein is this fixed with 32083ce?
-
yes
-
- changed status to closed
- Log in to comment
I would say we don't want to have any dependencies to RoBO anymore. But maybe please ask Aaron directly -- also about the branch.
Best, Marius