Commits

Shlomi Fish committed 05d2559

Convert t/45regex.t to Test::More and strict/warnings.

  • Participants
  • Parent commits 77f0400

Comments (0)

Files changed (1)

 #########################
 
-use Test;
-BEGIN { plan tests => 13 };
+use strict;
+use warnings;
+
+use Test::More tests => 13;
+
 use XML::LibXML;
 
-my $regex = '[0-9]{5}(-[0-9]{4})?';
-my $bad_regex = '[0-9]{5}(-[0-9]{4}?';
-my $nondet_regex = '(bc)|(bd)';
-my $re = XML::LibXML::RegExp->new($regex);
-ok( $re );
-ok( ! $re->matches('00') );
-ok( ! $re->matches('00-') );
-ok( $re->matches('12345') );
-ok( !$re->matches('123456') );
+{
+    my $regex = '[0-9]{5}(-[0-9]{4})?';
+    my $re = XML::LibXML::RegExp->new($regex);
 
-ok( $re->matches('12345-1234') );
-ok( ! $re->matches(' 12345-1234') );
-ok( ! $re->matches(' 12345-12345') );
-ok( ! $re->matches('12345-1234 ') );
+    # TEST
+    ok( $re, 'Regex object was initted.');
+    # TEST
+    ok( ! $re->matches('00'), 'Does not match 00' );
+    # TEST
+    ok( ! $re->matches('00-'), 'Does not match 00-' );
+    # TEST
+    ok( $re->matches('12345'), 'Matches 12345' );
+    # TEST
+    ok( !$re->matches('123456'), 'Does not match 123456' );
 
-ok( $re->isDeterministic );
+    # TEST
+    ok( $re->matches('12345-1234'), 'Matches 12345-1234');
+    # TEST
+    ok( ! $re->matches(' 12345-1234'), 'Does not match leading space');
+    # TEST
+    ok( ! $re->matches(' 12345-12345'), 'Leading space No. 2' );
+    # TEST
+    ok( ! $re->matches('12345-1234 '), 'Trailing space' );
 
-my $re2 = XML::LibXML::RegExp->new($nondet_regex);
-ok( $re2 );
-ok( ! $re2->isDeterministic );
+    # TEST
+    ok( $re->isDeterministic, 'Regex is deterministic' );
+}
 
-eval { XML::LibXML::RegExp->new($bad_regex); };
-ok( $@ );
+{
+    my $nondet_regex = '(bc)|(bd)';
+    my $nondet_re = XML::LibXML::RegExp->new($nondet_regex);
+
+    # TEST
+    ok( $nondet_re, 'Non deterministic re was initted' );
+    # TEST
+    ok( ! $nondet_re->isDeterministic, 'It is not deterministic' );
+}
+
+{
+    my $bad_regex = '[0-9]{5}(-[0-9]{4}?';
+    eval { XML::LibXML::RegExp->new($bad_regex); };
+    # TEST
+    ok( $@, 'An exception was thrown on bad regex' );
+}