Enable toggle behavior is inconsistent with behavior in popup

Issue #72 resolved
greiner12 created an issue

The current behavior of the enable toggle in the mobile options page is inconsistent with how the enable toggle behaves in the icon popup.

Behavior based on spec:

  • The toggle is "off" if current page's domain is whitelisted and "on" otherwise.
  • Switching it to "off" will add a whitelist filter for the domain.
  • Switching it to "on" will remove the whitelist filter for the domain.

Behavior in icon popup:

  • The toggle is "off" if current page is whitelisted and "on" otherwise.
  • Switching it to "off" will add a whitelist filter for the domain.
  • Switching it to "on" will
    • remove all whitelist custom filters
    • and disable all whitelist non-custom filters.

Preferrably, the two implementations share the same behavior as this is also what the Platform team expects based on the code in this code review.

Comments (3)

  1. Log in to comment