Commits

Abhishek Kulkarni committed e00b382 Draft

take another pass over the patch and fix minor quibbles

Comments (0)

Files changed (6)

orte/mca/ess/env/ess_env_module.c

         /* Error state = Nothing */
     }
 
- cleanup:
+cleanup:
     OBJ_DESTRUCT(&coll);
     return exit_status;
 }

orte/mca/plm/base/plm_base_launch_support.c

 
 void orte_plm_base_complete_setup(int fd, short args, void *cbdata)
 {
-	int rc;
+    int rc;
     orte_job_t *jdata, *jdatorted;
     orte_state_caddy_t *caddy = (orte_state_caddy_t*)cbdata;
 

orte/mca/snapc/full/snapc_full_global.c

                                          opal_buffer_t* buffer,
                                          orte_rml_tag_t tag,
                                          void* cbdata);
-static void snapc_full_process_orted_request_cmd(int fd, short event, void *cbdata);
 
 static void snapc_full_process_restart_proc_info_cmd(orte_process_name_t* sender,
                                                      opal_buffer_t* buffer);
                                            opal_buffer_t* buffer,
                                            orte_rml_tag_t tag,
                                            void* cbdata);
-static void snapc_full_process_cmdline_request_cmd(int fd, short event, void *cbdata);
 
 static int snapc_full_establish_snapshot_dir(bool empty_metadata);
 
             OPAL_OUTPUT_VERBOSE((10, mca_snapc_full_component.super.output_handle,
                                  "Global) Command: Job State Update (quick)"));
 
-            snapc_full_process_job_update_cmd(&(sender), buffer, true);
+            snapc_full_process_job_update_cmd(&sender, buffer, true);
             break;
 
         case ORTE_SNAPC_FULL_UPDATE_JOB_STATE_CMD:
             OPAL_OUTPUT_VERBOSE((10, mca_snapc_full_component.super.output_handle,
                                  "Global) Command: Job State Update"));
 
-            snapc_full_process_job_update_cmd(&(sender), buffer, false);
+            snapc_full_process_job_update_cmd(sender, buffer, false);
             break;
 
         case ORTE_SNAPC_FULL_UPDATE_ORTED_STATE_QUICK_CMD:
             OPAL_OUTPUT_VERBOSE((10, mca_snapc_full_component.super.output_handle,
                                  "Global) Command: Daemon State Update (quick)"));
 
-            snapc_full_process_orted_update_cmd(&(sender), buffer, true);
+            snapc_full_process_orted_update_cmd(sender, buffer, true);
             break;
 
         case ORTE_SNAPC_FULL_UPDATE_ORTED_STATE_CMD:
             OPAL_OUTPUT_VERBOSE((10, mca_snapc_full_component.super.output_handle,
                                  "Global) Command: Daemon State Update"));
 
-            snapc_full_process_orted_update_cmd(&(sender), buffer, false);
+            snapc_full_process_orted_update_cmd(sender, buffer, false);
             break;
 
         case ORTE_SNAPC_FULL_RESTART_PROC_INFO:
             OPAL_OUTPUT_VERBOSE((10, mca_snapc_full_component.super.output_handle,
                                  "Global) Command: Update hostname/pid associations"));
  
-            snapc_full_process_restart_proc_info_cmd(&(sender), buffer);
+            snapc_full_process_restart_proc_info_cmd(sender, buffer);
             break;
 
         case ORTE_SNAPC_FULL_REQUEST_OP_CMD:
             OPAL_OUTPUT_VERBOSE((10, mca_snapc_full_component.super.output_handle,
                                  "Global) Command: Request Op"));
 
-            snapc_full_process_request_op_cmd(&(sender), buffer);
+            snapc_full_process_request_op_cmd(sender, buffer);
             break;
 
         default:

orte/mca/snapc/full/snapc_full_local.c

                                           opal_buffer_t* buffer,
                                           orte_rml_tag_t tag,
                                           void* cbdata);
-static void snapc_full_process_hnp_request_cmd(int fd, short event, void *cbdata);
 
 static bool snapc_local_app_recv_issued = false;
 static int  snapc_full_local_start_app_listener(void);
                                        opal_buffer_t* buffer,
                                        orte_rml_tag_t tag,
                                        void* cbdata);
-static void snapc_full_local_process_app_update_cmd(int fd, short event, void *cbdata);
 
 static orte_snapc_full_app_snapshot_t *find_vpid_snapshot(orte_process_name_t *name );
 static int snapc_full_local_get_vpids(void);

orte/mca/sstore/central/sstore_central_local.c

 }
 
 void orte_sstore_central_local_recv(int status,
-                                      orte_process_name_t* sender,
-                                      opal_buffer_t* buffer,
-                                      orte_rml_tag_t tag,
-                                      void* cbdata)
+                                    orte_process_name_t* sender,
+                                    opal_buffer_t* buffer,
+                                    orte_rml_tag_t tag,
+                                    void* cbdata)
 {
     int ret;
     orte_sstore_central_cmd_flag_t command;

orte/mca/sstore/stage/sstore_stage_global.c

                                        opal_buffer_t* buffer,
                                        orte_rml_tag_t tag,
                                        void* cbdata);
-static void sstore_stage_global_process_cmd(int fd,
-                                              short event,
-                                              void *cbdata);
+
 static int process_local_pull(orte_process_name_t* peer, opal_buffer_t* buffer, orte_sstore_stage_global_snapshot_info_t *handle_info);
 static int process_local_push(orte_process_name_t* peer, opal_buffer_t* buffer, orte_sstore_stage_global_snapshot_info_t *handle_info);
 static int process_local_done(orte_process_name_t* peer, opal_buffer_t* buffer, orte_sstore_stage_global_snapshot_info_t *handle_info);