-
assigned issue to
We should recommend that people commit their patches to branches.
Its important that we support this, since if the openjdk approach is to commit a patch as a new commit, then hg's inability to delete changes stops us from pulling in the commits from upstream and merging the pull request.
This is also needed for people who are planning on opening multiple pull requests at the same time,
It might be the case that we just need to test this, and it works already. A documentation change is needed either way.
Comments (4)
-
-
-
assigned issue to
Paired with @richardwarburton to resolve issue, changes on its way via new commits and PR.
-
assigned issue to
-
-
- changed status to resolved
Issue has been resolved, changes accepted and merged into the Betterrev code-base via #53 (https://bitbucket.org/adoptopenjdk/betterrev/pull-request/53/fixes-issue-26/diff).
- Log in to comment
Assigned to self, on Martijn's suggestion.