Anonymous avatar Anonymous committed 687c1cb

taskhandle: increment `self.done` before informing observers.
Because self.done is incremented after `self.handle._inform_observers()`
an observing function will never see `JobSet.get_percent_done() == 100`.
Thanks to dysiode for reporting.

Comments (0)

Files changed (1)

rope/base/taskhandle.py

 
     def finished_job(self):
         self.check_status()
+        self.done += 1
         self.handle._inform_observers()
         self.job_name = None
-        self.done += 1
 
     def check_status(self):
         if self.handle.is_stopped():
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.