Crash at startup with experimental Linux AppImage

[Carmelo DrRaw]

I am currently trying to prepare an AppImage package for ART, but the application crashes systematically at startup. I could backtrace the crash to this line of code: https://bitbucket.org/agriggio/art/src/1fa55f76fc125c4255df79154a4dd04eb0757e45/rtengine/procparams.cc#lines-1752

‌

If I replace options.rtSettings.srgb with a fixed string like “sRGB” then the crash disappears, hence I suspect a badly initialized string in the rtSettings structure. Could this be possible?

[agriggio]

The profile should be called “RTv4_sRGB”. Maybe when building the AppImage the file is not found for some reason? Could this be possible? If you set the string to “sRGB”, the internal profile will be used, so there’s no file searching going on. That could explain the difference.

[Carmelo DrRaw]

I just checked, and manually setting the value to “RTv4_sRGB" does not trigger a crash, so the problem is likely somewhere else… https://bitbucket.org/aferrero2707/art/src/cba25b0ab6e8c981a0a0ee7a51d318b98a7c9b87/rtengine/procparams.cc#lines-1745

[agriggio]

ok, can I download the appimage from somewhere perhaps?

[agriggio]

ok, I found something suspicious. I’ll try to push a patch asap

[agriggio]

Can you try with this version?

https://bitbucket.org/agriggio/art/commits/0a89eb6bdfd2c0ae93ba71f33a3009a74e0b43f0

[Carmelo DrRaw]

Still crashing…

This modified code also crashes in the second cout:

‌

ColorManagementParams::ColorManagementParams() :
    inputProfile("(cameraICC)"),
    toneCurve(false),
    applyLookTable(false),
    applyBaselineExposureOffset(true),
    applyHueSatMap(true),
    dcpIlluminant(0),
    workingProfile("ProPhoto"),
    outputProfile("RTv4_sRGB"),
    outputIntent(RI_RELATIVE),
    outputBPC(true)
{
    std::cout<<"options.rtSettings.srgb:"<<std::endl;
    std::cout<<options.rtSettings.srgb<<std::endl;
}

‌

[agriggio]

please send me a link to the appimage and I’ll take a look, thanks!

[agriggio]

ok, I found something else… will push another fix (hopefully working) asap

[agriggio]

Can you try with 180f67a178f6a8486d0f9607a0154eec77195ac7 ?

[Carmelo DrRaw]

Your last commit seems to fix the crash! If you have a linux system at hand, you can download and test the AppImage from here: https://github.com/aferrero2707/art-appimage/releases/tag/nightly

I still have to test it on some images…

[Serge Moreau]

Works here on Kde neon (ubuntu 18,04)

Thanks a lot to both of you.

SM

[agriggio]

I quickly tested on ubuntu 16.04 and it seems to work fine. If you’re not doing this already, you might consider bundling exiftool, so that nothing is required to get proper Canon CR3 support.

In any case, thanks a lot for your help!

[Serge Moreau]

I have got one, bundle to the exif tools works as you expected after installation of the latest version of exiftools. So all is OK on ubuntu 18,04

[Carmelo DrRaw]

@Serge Moreau @agriggio thanks for the feedback! Could you explain in more detail what is needed for CR3 support, and what should be eventually included in the AppImage bundle?

[agriggio]

@Carmelo DrRaw ART supports CR3 decoding out of the box, but it relies on exiftool for metadata. You can configure in the preferences the path to the exiftool executable, but by default ART looks for it in the data dir (i.e. the top directory if you build in “bundle mode”, which I suppose is what the appimage does). So, it should be enough to unpack the exiftool tarball somewhere in the appimage and then symlink to the top directory. I didn’t try though, I’m just guessing…

[agriggio]

btw how do I call for your attention with the “@” thing when your username has spaces in it? (Sorry for the dumb and OT question… )