lens correction

Issue #28 new
Bertrand Roessli created an issue

Hello,

It seems that ART does not apply lens correction with my Olympus camera.

Even in manual mode I cannot select the camera model.

It does it automatically in Rawtherapee.

Thank you,

B. Roessli

Comments (23)

  1. agriggio repo owner

    hi,

    what versions of both programs are you using? Are you compiling them yourself or using pre-built binaries?

  2. Bertrand Roessli reporter

    Hello,

    In both cases I am using an appimage for Debian. Version 1.1 for ART and 5.8 for Rawtherapee.

    Thank You,

    B. Roessli

  3. Carmelo DrRaw

    Would it be possible to have a sample RAW file to investigate the problem? It might also be due to differences in the way the camera/lens information is retrieved in the two programs…

  4. Johan Thor

    I have somewhat the same issue. I’m on Ubuntu 18.04 and have tried both the ppa from Dariusz Duma and compiling myself with the same result: I can’t select anything from the dropdown when selecting “Manually” in “Profiled Lens Correction”. Choosing a LCP-file works, however.

  5. agriggio repo owner

    what version of lensfun are you using? again, here I see no issues… so, I need more detail to debug this

  6. Johan Thor

    I use two packages from Ubuntu:

    1. liblensfun-data-v1: liblensfun-data-v1/focal,focal,now 0.3.2-5 all [installed,automatic]
      Lens Correction library - Data
    2. liblensfun1: liblensfun1/focal,now 0.3.2-5 amd64 [installed,automatic]
      Lens Correction library - Runtime files

    How can I further investigate? (On this machine, I’m running the prebuilt debs from Dariusz ppa.)

  7. agriggio repo owner

    I’ll try to set up a VM with ubuntu 18.04 and see what is going wrong… might take a few days though

  8. Johan Thor

    Please, don’t hesitate to ask me to do some tests if you want - I’d be glad to help! I really like what you have done with ART! 🙂

  9. agriggio repo owner

    If you can, maybe upload a screencast showing the problem. Other than that, I don’t know yet, I need to think about it. But thanks for the help!

  10. agriggio repo owner

    oh, you can also test with raw files from different cameras and lenses, to see whether this only happens with specific models

  11. Johan Thor

    I just tried with a raw file from a Nikon D700, which should be supported (?) by lensfun, but to no help.

    Below is a screenshot, the dropdowns are not selectable: (I’ll have to learn how to make a screencast…!)

  12. Bertrand Roessli reporter

    May-be this is related to the problem I also have that I cannot open the sub-menus in the film simulation if I opened it a few times. I submitted a bug report to Rawtherapee and I was said to update the GTk library and recompile. But I am using an appimage…

    “upgrade GTK+ to the latest version and recompile.”

    https://github.com/Beep6581/RawTherapee/issues/5537

    Thanks

  13. agriggio repo owner

    Thanks @Bertrand Roessli for the info. Indeed, that might be relevant. I’ll try to investigate.

    Regarding the raw, we didn’t receive anything, but perhaps this is not necessary now.

  14. David Lefevre

    Hello,
    I have a same issue, with Art 1.2 Appimage on Ubuntu 18.04. I tried with CR2 and CR3 files, i.e. two different cameras, the choices for the camera and for the lens profile are grayed out.
    If I switch to the Art 1.2 version of the PPA, I can select the camera and the lens.
    But, with the version of PPA, i have no exifs with the CR3 files, so i decide to use Adobe DNG Converter.
    Unfortunately, the version of the PPA gives an error when writing the jpg file when converting the DNG. No problem with saving Png or Tiff files.
    And this same DNG is exported very well in jpg with the AppImage version.

    So in the meantime I use the AppImage version with CR2 or CR3 files and if I need a lens profile, I pick up in the Adobe database.

    Thank you,

  15. Carmelo DrRaw

    @agriggio @David Lefevre @Bertrand Roessli If this is a bug related to GTK3, then it will take a certain time to fix it for the AppImage. I will have to compile a newer GTK3 version from sources instead of using the one provided with CentOS7, which means I am taking a deep dive into the dependencies hell…

  16. David Lefevre

    Thank you very much agriggio, I missed the upgrade to Exiftool. It works great now with the PPA version.
    For the DNG bug, which only happens with the export in jpg, here are the requested files. Thank you.

    https://we.tl/t-1KtC8z0knB

  17. Bertrand Roessli reporter

    Hi

    I tried to compile Rawtherapee and I ran into

    Warning! You are using GTK+ version 3.24.5 which is known to have an issue
    where combobox menu scroll-arrows are missing when a Gtk::ComboBox list
    does not fit vertically on the screen. As a result, users of your build
    will not be able to select items in the following comboboxes: Processing
    Profiles, Film Simulation, and the camera and lens profiles in Profiled
    Lens Correction.

    May-be this helps,

    B. Roessli

  18. Bertrand Roessli reporter

    Hello,

    Thanks for the comment.

    I upgraded Debian Buster to “testing” wih comes with libgtk 3.24.18 

    and compiled Art1.3 and indeed the problems seem to be solved.

    The only problem left is that

    ART still does not recognise my camera model and I could not find the

    Olympus Om-D EM10 II in the list. Many many others appear in the lists on the other hand.

    So it seems that this could be a problem of liblensfun-dev

    which comes now with version 0.3.2-5 while it was 0.3.2-4 in Debian Buster .

    (although cmake says: Found lensfun, version 0.3.2.0 ?)

    The lens is recognised on the other hand.

    B. Roessli

    PS The Appimage of Rawtherapee does the lens correction automatically

    I will think further…

  19. Bertrand Roessli reporter

    Update:

    I has probably nothing to do with lensfun.

    I can find my camera model if I go straight to it when I open the lens correction menu.

    If I play with the different camera brands and models than no list appear for Olympus and e.g. Canon any more. The problem is similar to the issue in the “film simulation” that I described in the previous post and that is still present now.

    The problem really seems to be related to libgtk and is still not competely solved, it seems.

    B. Roessli

  20. Log in to comment