Pull requests

#6 Declined
Repository
linuxdynasty linuxdynasty
Branch
master
Repository
agronholm agronholm
Branch
master

Added RethinkDB Jobstore

Author
  1. Allen Sanabria
Reviewers

Comments (2)

  1. Alex Grönholm repo owner

    Make sure you've read the contributor guide before sending a new pull request. In particular, the last PR didn't have any tests. You should also name your module rethinkdb.py (use from future import absolute_import for that to work on Python 2). Respect the coding style use in the rest of the project.

  2. Allen Sanabria author

    For the reasons stated above, is why I declined my pull request, since I based my job store on your 2.1 branch and not your latest which contains the new style. I will make sure the next request follows the above guidelines.