Jason R. Coombs avatar Jason R. Coombs committed a3eacd4

Fix test failures on Python 3

Comments (0)

Files changed (2)

         # one added here.
         if '\n' in string:
             raise ValueError("Carriage returns not allowed in privmsg(text)")
-        bytes = string.encode('utf-8') + '\r\n'
+        bytes = string.encode('utf-8') + b'\r\n'
         # According to the RFC http://tools.ietf.org/html/rfc2812#page-6,
         # clients should not transmit more than 512 bytes.
         if len(bytes) > 512:

irc/tests/test_client.py

 	server.connect('foo', 6667, 'bestnick')
 	server.privmsg('#best-channel', 'You are great')
 	socket_mod.socket.return_value.send.assert_called_with(
-		'PRIVMSG #best-channel :You are great\r\n')
+		b'PRIVMSG #best-channel :You are great\r\n')
 
 @mock.patch('irc.client.socket')
 def test_privmsg_fails_on_embedded_carriage_returns(socket_mod):
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.