fl.info~ crash on windows - similar to fl.expr~ crash

Issue #103 resolved
Former user created an issue

I get an assert error with the latest windows build when I attempt to make fl.info~

Comments (8)

  1. Alex Harker repo owner

    Can I get a patch? I can’t see anywhere obvious that fl.info~ is using vectors that is not framework code - therefore this could be a broader issue. It isn’t quite the same as the fl.expr~ crashes were about being before the beginning of the vector - this suggests that the vector access is out of range and that sounds more like a bug, than MS being paranoid.

  2. Alex Harker repo owner

    I cannot reproduce this error if I build from master (debug - 64bit) and create an fl.info~ object on windows.

    I’m sure there’s something going on here, but I’m not sure what it is as there is nothing obvious in the code (the object doesn’t use vector except in the same way all FrameLib_DSP objects and max objects do. If I can get a repeatable error I’ll fix it, but without that it is a mystery.

  3. Alex Harker repo owner

    The only thing I can think here is that you typed something in the box that I don’t know about and that is what causes the error.

  4. Former user Account Deleted reporter

    I cannot send a patch because making a patch to reproduce the error causes a crash. I can recreate by opening a new patcher and attempting to make an fl.info~ object. I need to check my build and I am not near the windows machine right now but from what I can remember is built immediately after the fix to fl.expr~ was pushed to your master. I will test further tonight with a clean and bleeding edge build to see if it can be reproduced.

  5. Former user Account Deleted reporter

    Okay, I cannot build now after pulling your retarget of the vs project to 2017 (v140) build tools. I have installed these, but currently cannot get a compile to work on the Debug /x64 configuration. I get lots of errors - mostly pertaining to Error C4996 std::copy::_Unchecked_iterators. I hesitate to upload the errors to something like pastebin or hastebin as they expire - but if we can get a build going soon then it won’t really matter.

    To clarify - I am on the latest version of visual studio. I think in the future the latest version of visual studio should be targeted as I had to create an account and sign up to the dev program of microsoft just to get the older build tools.

    https://pastebin.com/3XCptsKq

  6. Alex Harker repo owner

    Just retarget on your repo to build (and don’t push the changes - so either do it on a branch or do it on your working copy and don’t keep the changes, or stash) . If I retarget then I have to upgrade, which is a pain, and I may do in time, but not right now. And right now I will be the key person building, so….

  7. Alex Harker repo owner

    BTW - all of the “errors” about std::copy (as they explain to you) are actually warnings and could be turned off.

  8. Log in to comment