Add support for progress syncing with website
Blocked until a better API is released
The is now a sufficient API to support this.
- save-time
- get-saved-time
- get-all-saved-times
The video endpoint API also includes a saved_time field now.
Comments (9)
-
reporter -
Account Deleted Hey Alec,
I’m interested in this feature. I’m willing to take a stab at it and make some pull requests. I’m curious why your previous attempt was abandoned? Was there a blocking issue you ran into or would you just prefer to simplify the app with the refactor you’ve linked to?
Neil
-
reporter Hi Neil,
Thanks for your interest!
The reason I abandoned my work on this feature was partly due to thinking it would be much cleaner with the refactor you linked to, but primarily because my personal time available to work on this project basically disappeared.
I'm happy to look at a pull request for this (and I won't block it on the proposed refactor), but you should also be aware that Giant Bomb forum user Odc also mentioned maybed working on video progress syncing here:
https://www.giantbomb.com/forums/general-discussion-30/amazon-fire-tv-android-tv-the-giant-bomb-enthusias-1805547/?page=5#js-message-9009299Unless that's you as well, you may want to message him and make sure you aren't duplicating your efforts. There was also a recent fork here https://bitbucket.org/odes1/gbenthusiast/src/master/ that might be Odc? Not sure. I don't see any commits in that fork yet though.
Alec
-
reporter - edited description
Blocked until a better API is released
-
reporter - edited description
Blocked until a better API is releasedThe is now a sufficent API to support this.
- save-time
- get-saved-time
- get-all-saved-times
The video endpoint API also includes a saved_time field now.
-
Account Deleted Thanks for the heads up! I’ll update that thread and try to sync up. I agree the refactor would simplify things, so I’m taking a stab at it. I have some of my changes up here: https://bitbucket.org/neilgoodman/gbenthusiast/src/issue-46-and-53/
I may send some pull requests over in the next few weeks as I plug away at it. I’ll update issue 53 with what I’m thinking in terms of implementation.
-
I have a branch locally that adds this functionality, but I do not have the permission to create branches through Bitbucket directly, nor through
git push --set-upstream origin
Would you mind granting that permission?
edit: IDK if that is something open source people don’t generally do. If not - sorry! I could fork it if that’s better for you
-
reporter That’s great to hear!
A fork + pull request would be ideal.
-
I literally did not know you could even create a pull request from a fork until like, an hour ago!
https://bitbucket.org/alecgdouglas/gbenthusiast/pull-requests/3/update-to-start-syncing-with-gb-api
- Log in to comment
Some WIP here: https://bitbucket.org/alecgdouglas/gbenthusiast/branch/video_progress_sync (pretty much abandoned at this point)
Might be better to do a larger refactor instead to move away from local storage and just query the website for videos on load, i.e. https://bitbucket.org/alecgdouglas/gbenthusiast/issues/53/refactor-remove-local-storage-query-from