Anonymous avatar Anonymous committed 1b0405b Draft

Show icons in order using WhenAll

Comments (0)

Files changed (1)

FaviconBrowser/MainWindow.xaml.cs

 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using System.Net;
+using System.Threading.Tasks;
 using System.Windows;
 using System.Windows.Controls;
 using System.Windows.Media.Imaging;
             InitializeComponent();
         }
 
-        private void GetButton_OnClick(object sender, RoutedEventArgs e)
+        private async void GetButton_OnClick(object sender, RoutedEventArgs e)
         {
-            foreach (string domain in s_Domains)
+            IEnumerable<Task<Image>> tasks = s_Domains.Select(GetFavicon);
+            Task<Image[]> allTask = Task.WhenAll(tasks);
+            Image[] images = await allTask;
+            foreach (Image eachImage in images)
             {
-                AddAFavicon(domain);
+                AddAFavicon(eachImage);
             }
         }
 
-        private async void AddAFavicon(string domain)
+        private async Task<Image> GetFavicon(string domain)
         {
             WebClient webClient = new WebClient();
             byte[] bytes = await webClient.DownloadDataTaskAsync("http://" + domain + "/favicon.ico");
-            Image imageControl = MakeImageControl(bytes);
+            return MakeImageControl(bytes);
+        }
+
+        private void AddAFavicon(Image imageControl)
+        {
             m_WrapPanel.Children.Add(imageControl);
         }
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.