Not all rules find all problems all the time; was:"Non-copying property of immutable NSCopying type" does not find all instances

Issue #65 wontfix
Appmire created an issue

Hi Ali,

I had a situation, where faux pas did not find all instances for the above mentioned rule. But after fixing something else (Old syntax +[NSNumber numberWithDouble:]), the remaining issues were found. The same happend to me with some other rule. I only had one thing left to fix in one group and only had one other group and after fixing the last thing of one group, I got a bunch of new errors. This is not so nice, because sometimes I might deliberately not fix an issue and then i would not be able to see some remaining issues.

One other suggestion: you could check for [NSString stringWithFormat:@"%s",<somehting>] and suggest to replace it with @(<something>). You are already doing it for +[NSString stringWithCString:encoding:]

Kind regards, Nikolas Mayr

Comments (2)

  1. Ali Rantakari repo owner

    Generally Faux Pas diagnostics should be emitted deterministically, but sometimes changing existing code will affect how the Clang compiler interprets some other part of the code, leading to changes in the diagnostics Faux Pas is then able to put out.

  2. Log in to comment