Not all missing translations are found

Issue #86 invalid
Gary Kash created an issue

I've found that FauxPas consistently misses non-translated phrases. Here are some examples of phrases that are being missed:

button.setTitle(NSLocalizedString("Join Group", comment: "button title"), forState: .Normal)
...
label.text = NSLocalizedString("Let’s get this party started!", comment: "")
...
button.setTitle(NSLocalizedString("Invite Others to Join", comment: "button title"), forState: .Normal)
...
button.setTitle(NSLocalizedString("Post a Welcome Message", comment: "button title"), forState: .Normal)
...

The "Join Group" translation is not in any of the translation .strings files but FauxPas fails to report that "Join Group" is missing. In this particular example, there are about a dozen phrases that are being missed. The project is fairly large and has 14 languages translated, runs cocoapods and has many dependancies and use both Swift and Objective-C. Missing translations are in both languages.

Comments (7)

  1. Ali Rantakari repo owner

    Thanks for reporting this. Faux Pas does not yet support Swift, so it's normal for it to not warn about missing translations for localized strings defined in Swift code. If you have similar cases in Objective-C code, please ensure that Faux Pas is checking the source code file that contains the localized string usage, and post an example of the code.

  2. Log in to comment