(with patch) Conflicting short option -t for patchbomb and tasks.

Johan Samyn avatarJohan Samyn created an issue

When using both the tasks and the patchbomb extension, there is a conflict between the short -t option they both expose. As the patchbomb's -t is for specifying the recipient(s), it rules imho. So I made a patch that removes the short option from tasks.py, as it also has the --task option to achieve this. As I was unable to contact you, alu, and I don't think I can push a cset uphere, I include the patch in this issue.

# HG changeset patch
# User Johan Samyn <johan.samyn@gmail.com>
# Date 1264880969 -3600
# Node ID 637b31e8f635f14601c235b41b773033a5984cf9
# Parent  73e7848ef98733bdda8ca1515fca8793a752b44d
tasks.py: remove short task option (-t) for patchbomb

diff --git a/hgext/tasks.py b/hgext/tasks.py
--- a/hgext/tasks.py
+++ b/hgext/tasks.py
@@ -190,7 +190,7 @@
    Use 'hg export [TASK]' to export all changesets associated with the given
    task.

-    Use 'hg email -t [TASK]' to create a patchbomb containing all changesets
+    Use 'hg email --task [TASK]' to create a patchbomb containing all changesets
    associated with the given task.

    Use 'hg transplant -t [TASK]' to transplant all associated changsets in a
@@ -722,7 +722,7 @@
        if patchbomb:
            entry = extensions.wrapcommand(patchbomb.cmdtable, 'email',
                tasksemail)
-            entry[1].append(('t', 'task', '',
+            entry[1].append(('', 'task', '',
                _('email all changesets in task TASK')))
    except:
        pass

Comments (4)

  1. Johan Samyn

    Hi, I'm pasting my patch again, based on the latest tip changeset.

    # HG changeset patch
    # User Johan Samyn <johan.samyn@gmail.com>
    # Date 1264951699 -3600
    # Node ID 29987d26b137db5662791bdccd37124381b66354
    # Parent  3e41ef453b310ed4c3f42fb2ea43bb9d74b6aef3
    removed short task option (-t) for patchbomb
    
    diff --git a/hgext/tasks.py b/hgext/tasks.py
    --- a/hgext/tasks.py
    +++ b/hgext/tasks.py
    @@ -190,7 +190,7 @@
         Use 'hg export [TASK]' to export all changesets associated with the given
         task.
     
    -    Use 'hg email -t [TASK]' to create a patchbomb containing all changesets
    +    Use 'hg email --task [TASK]' to create a patchbomb containing all changesets
         associated with the given task.
     
         Use 'hg transplant -t [TASK]' to transplant all associated changsets in a
    @@ -723,7 +723,7 @@
             if patchbomb:
                 entry = extensions.wrapcommand(patchbomb.cmdtable, 'email',
                     tasksemail)
    -            entry[1].append(('t', 'task', '',
    +            entry[1].append(('', 'task', '',
                     _('email all changesets in task TASK')))
         except:
             pass
    
  2. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.