Request rewiew of Jérôme Pouiller's multibyte character support patch

[pancho horrillo]

Hi, Adam!

I am the current maintainer of the par package in the AUR¹.

I kindly request that you review and consider accepting this patch by Jérôme Pouiller, which adds support for multibyte characters to par. Note that the archlinux community have been using it for years without issues. Also note that the patch is against version 1.52 of par, and some updating is needed.

Thank you very much in advance, and thanks a lot for giving par to the world. Congrats on the new release!

[1]: https://aur.archlinux.org/packages/par

[2]: http://sysmic.org/dotclear/index.php?post/2006/06/22/55-add-multibyte-characters-support-in-par

[Matěj Cepl]

Unfortunately even with my port of the patch, it still doesn’t format correctly attached format.txt file:

‌

stitny~$ par 42rj <format.txt
/****************************************/
/* English is a  West Germanic language */
/*heavily  influenced,   in  comparison */
/*with  other  Germanic  languages,  by */
/*French   and   Latin.    On   appelle */
/*français (et française au féminin) */
/*les habitants de la France            */
/*                                      */
/* [ Ανήκει επίσης στο ] */
/*βαλκανικό γλωσσικό ] */
/*δεσμό.                         ] */
/* [                                  ] */
par error:
Cannot justify.
stitny~$ 

‌

[Matěj Cepl]

Ah, the problem is only with justification:

‌

stitny~/.c/d/v/p/vis-par (rewrite *)$ par 42r <~/format.txt
/****************************************/
/* English is a West Germanic language  */
/*heavily influenced, in comparison     */
/*with other Germanic languages,        */
/*by French and Latin.  On appelle      */
/*français (et française au féminin) */
/*les habitants de la France            */
/*                                      */
/* [ Ανήκει επίσης στο ] */
/*βαλκανικό γλωσσικό ] */
/*δεσμό.                         ] */
/* [                                  ] */
/* [ Русский язык          ] */
/*— язык русских,        ] */
/*государственный      ] */
/*язык России и            ] */
/*[ Белоруссии,             ] */
/*ранее — язык             ] */
/*межнационального    ] */
/*общения СССР             ] */
/*                                      */
/* اللغة العربية            */
/*هي لغة سامية،              */
/*مشتقة عن السريانية    */
/*(نسب ة الى سورية)         */
/*والآرامية والعبرية   */
/*و الأكادية، و هي         */
/*لغة العرب، سكان شبه   */
/*الجزيرة                        */
/*                                      */
/****************************************/
stitny~/.c/d/v/p/vis-par (rewrite *)$ 

‌

[Matěj Cepl]

Hmm, something’s wrong:

‌

stitny~$ echo 'Русский язык — язык русских, государственный язык России и Белорус
сии, ранее — язык межнационального общения СССР'|/usr/bin/par ET4w65p1
par error:
Bad argument: r
stitny~$ 

‌

[Matěj Cepl]

The problem is that when I set PARINIT environment variable program crashes. But it is strange:

‌

$ export PARINIT='rTbp2hgqRB=.,?_A_aQ=_s>|'
$ echo 'sds sd asd sdfsadfsdf asdf sdf sdf sdfasdf sdfa sdf asdfasd afsdfas dfa sdf asdfa sdfas dfasdf asdfa sdf as dfa sdf asd fasdfasdfas asd fasdf asdfasdf a asdfa sdf as dfasd fasdfa sdf sdfasdf.'|par 45
par error:
Bad argument: r
$ 

But this works

‌

$ unset PARINIT
$ echo 'sds sd asd sdfsadfsdf asdf sdf sdf sdfasdf sdfa sdf asdfasd afsdfas dfa sdf asdfa sdfas dfasdf asdfa sdf as dfa sdf asd fasdfasdfas asd fasdf asdfasdf a asdfa sdf as dfasd fasdfa sdf sdfasdf.'|par 45
sds sd asd sdfsadfsdf asdf sdf sdf sdfasdf
sdfa sdf asdfasd afsdfas dfa sdf asdfa sdfas
dfasdf asdfa sdf as dfa sdf asd fasdfasdfas
asd fasdf asdfasdf a asdfa sdf as dfasd
fasdfa sdf sdfasdf.
$ PARINIT='rTbp2hgqRB=.,?_A_a Q=_s>|' echo 'sds sd asd sdfsadfsdf asdf sdf sdf sdfasdf sdfa sdf asdfasd afsdfas dfa sdf asdfa sdfas dfasdf asdfa sdf as dfa sdf asd fasdfasdfas asd fasdf asdfasdf a asdfa sdf as dfasd fasdfa sdf sdfasdf.'|par 45
sds sd asd sdfsadfsdf asdf sdf sdf sdfasdf
sdfa sdf asdfasd afsdfas dfa sdf asdfa sdfas
dfasdf asdfa sdf as dfa sdf asd fasdfasdfas
asd fasdf asdfasdf a asdfa sdf as dfasd
fasdfa sdf sdfasdf.
$ 

‌