- changed title to Please make it compatible with Shelf 0.6.0
Please make it compatible with Shelf 0.6.0
pub didn't inform about the incompatibility of shelf 0.6.0 and shelf_auth 0.3.0. I still don't know why, but the my app fails because of a missing scriptName.
Comments (10)
-
reporter -
repo owner - changed status to resolved
done
-
reporter Thanks!
-
reporter Seems https://bitbucket.org/andersmholmgren/shelf_auth/src/fd1aa1bb9985a02ba884bd46a91e206d56077c6a/lib/src/authentication_impl.dart?at=master is still referencing the getter
request.fieldName
which was renamed torequest.handlerPath
I couldn't find the source of 0.4.0 otherwise I had tried to create a PR. -
reporter The previous link should be https://bitbucket.org/andersmholmgren/shelf_auth/src/fd1aa1bb9985a02ba884bd46a91e206d56077c6a/lib/src/authentication_impl.dart?at=master#cl-92
I had to comment out https://bitbucket.org/andersmholmgren/shelf_auth/src/fd1aa1bb9985a02ba884bd46a91e206d56077c6a/lib/src/authentication_impl.dart?at=master#cl-91 otherwise I got an exception in shelf/src/request.dart line 302
-
repo owner Apologies for stuffing that up. Unfortunately, we need https://github.com/octobyte/shelf_exception_response/issues/3 first. Given how unresponsive they have become I suspect we are going to have to clone their package in pub. Thoughts?
I have pushed 0.4.0 now.
Note: the examples depend on shelf_bind which also needs upgrading after shelf_exception_response. Maybe I need to move those examples out of shelf_auth as it complicates dependencies
-
reporter No apology necessary. Thanks a lot for your great support. I was thinking about suggesting just that but I'm going on vacation tomorrow til Sunday. If he continues maintaining it eventually you could switch back any time.
-
repo owner I'd actually like to split it in half anyway. My Libs really just depend on the exceptions (except the examples) and those don't change much. They don't depend on external Libs like shelf or xml which would mean it's only mojito that actually depends on the shelf part. Enjoy your holidays
-
reporter I haven't actually checked this in your code or pubspec.yaml. Would it help to just use dev_dependencies or are you doing that anyway (https://code.google.com/p/dart/issues/detail?id=22054)
-
repo owner The Libs I use in the examples only are dev dependencies but unfortunately it doesn't help this issue.
- Log in to comment