Anonymous avatar Anonymous committed a5f2aa3

filedialogs: do not shadow QTableView.selectionView() method (fixes #2193)

This fixes a crash that happens with PyQT 4.9, introduced in 761551739d52edf8b5.

Comments (0)

Files changed (2)


                 msg = ''
-        self.repoview.selectionChanged.connect(checkValidSelection)
+        self.repoview.revisionSelectionChanged.connect(checkValidSelection)
         self.contentframe = QFrame(self.splitter)


     revisionAltClicked = pyqtSignal(object)
     revisionSelected = pyqtSignal(object)
     revisionActivated = pyqtSignal(object)
-    selectionChanged = pyqtSignal(QItemSelection, QItemSelection)
+    revisionSelectionChanged = pyqtSignal(QItemSelection, QItemSelection)
     menuRequested = pyqtSignal(QPoint, object)
     showMessage = pyqtSignal(unicode)
         if not QFontMetrics(self.font()).inFont(QString(u'\u2327').at(0)):
             model.unicodexinabox = False
-        self.selectionModel().selectionChanged.connect(self.selectionChanged)
+        self.selectionModel().selectionChanged.connect(self.revisionSelectionChanged)
         self._rev_history = []
         self._rev_pos = -1
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.