Klaas van Schelven committed ebda373

Bugfix: reverse() also pushed into _dfs()

This is a further fix on #15a4eadfdea8

in that commit

was replaced by

where dfs contained the SortedSet.

This broke the order of the dependencies.

I've now restored this by pushing reversed into _dfs. Rather than
calling reversed() all the time I've changed the appending of results
into prepending.

This is all in untested territory. I.e. tests run but they
also did when stuff was broken in the previous commits.

Comments (0)

Files changed (1)


     # We need to apply all the migrations this one depends on
     for n in children:
-        for result in _dfs(n, get_children, path):
-            results.append(result)
+        results = _dfs(n, get_children, path) + results
     return _dfs(start, get_children, [])
 def depends(start, get_children):
-    return list(reversed(dfs(start, get_children)))
+    return dfs(start, get_children)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.