Pull requests

#111 Merged
Repository
kkumler kkumler
Branch
default
Repository
andrewgodwin andrewgodwin
Branch
default

Fix #1230 - MySQL CREATE TABLE storage engine

Author
  1. Kris Kumler
Reviewers
Description

Adding, for MySQL, ENGINE=%s, etc. if STORAGE_ENGINE is defined.

Updated to remove whitespace changes automatically done by editor.

Comments (5)

  1. Andrew Godwin repo owner

    Thanks, much better now. Couple of observations:

    • I think the mutation of create_table_sql in init is going to be affecting the class' copy, not the instance's copy, but I can't remember the exact semantics of += with class attributes. Are you sure/could you check?

    • create_table appears to be overridden in mysql.py for no reason

    1. Kris Kumler author
      • create_table_sql checked out okay, but easily changed to an assignment anyway for clarity, which will also create an instance variable.
      • Removed the create_table override.