Pull requests

#83 Merged
Repository
craigds craigds
Branch
default
Repository
andrewgodwin andrewgodwin
Branch
default

fix nasty silent commits in db.rename_table() when using postgres.

Author
  1. craigds
Reviewers
Description

silent commits are super bad/confusing. Also unnecessary in this case :D

  • Learn about pull requests

Comments (4)

  1. Andrew Godwin repo owner

    I feel like this was added due to Postgres emitting a "pending trigger events" warning on table renames after columns were added/removed - have you tested this still works in that case?

    1. craigds author

      Yes, seems to work fine even after adding/removing columns on the table. Also pending trigger events problems can usually be solved with SET CONSTRAINTS ALL IMMEDIATE;