Pull requests

#136 Open
Repository
bobsilverberg
Branch
mysql_fix
Repository
andrewgodwin
Branch
default

Update mysql SET statement to address issue #1227

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update default
hg pull -r mysql_fix https://bitbucket.org/bobsilverberg/south
hg merge mysql_fix
hg commit -m 'Merged in bobsilverberg/south/mysql_fix (pull request #136)'
Author
  1. bobsilverberg
Reviewers
Description

This addresses the problem as described at http://south.aeracode.org/ticket/1227. I encountered this when trying to run a migration.

This is my first time using South, so I'm not sure if this patch is sufficient, or if we need some conditional code around mysql versions.

  • Learn about pull requests

Comments (3)

  1. Andrew Godwin repo owner

    Do you know what version the default_ prefix was introduced in? I presume a deprecation warning now means it arrived a while ago, as otherwise this is going to need some messy version-detecting code.

  2. Andrew Godwin repo owner

    Unfortunately not, I'd want to support 5.4 as well as I still know a few places that are on it. You'll have to change it to do a version query to the server, and then do some reasonably bulletproof version parsing to see which one it can send.