Read database is slow

Issue #12 resolved
Alireza Khorshidi created an issue

Probably the reason is that, reading of one database happens multiple times. Should try to reduce it as much as possible:

https://bitbucket.org/andrewpeterson/amp/src/f8612f4754c60060c2c3f7498589c4b5a754edcc/utilities.py?at=master&fileviewer=file-view-default#utilities.py-545

Comments (4)

  1. Alireza Khorshidi reporter

    Thanks Jake! There was a bug in your implementation, as well as the previous version of the code for reading databases. I fixed the bug, extended the tests folder, and sped up reading databases (now it reads within a single iteration only). These changes are performed in the commits 22a0c4d and d77911f.

  2. Alireza Khorshidi reporter

    Reading databases is still a bit slower than reading json files, but this is probably due to the nature of db reading data line by line, as compared to json loading data all at once.

  3. Log in to comment