range(1,2) in tests

Issue #151 new
andrew_peterson repo owner created an issue

I think the for loop does nothing in at least the Zernike test. It says for cores in range(1,2). But range(1,2) is (confusingly) just [1]; we need range(1,3) to give [1,2].

Comments (1)

  1. andrew_peterson reporter

    There are a couple still around that should be fixed:

    slim$ grep -r "range(1,"
    misc_test/rotated_atoms_test.py:        for i in range(1, len(atoms)):
    consistency_test/gaussian_test.py:        for cores in range(1, 2):
    consistency_test/zernike_test.py:        for ncores in range(1, 3):
    consistency_test/gaussian_neural_test/train_test.py:        for cores in range(1, 2):
    CuOPd_test/gaussian_neural_test/train_test.py:        for cores in range(1, 6):
    CuOPd_test/gaussian_neural_test/train_test.py:        for cores in range(1, 4):
    CuOPd_test/gaussian_neural_test/force_call_test_tflow.py:        for cores in range(1, 6):
    CuOPd_test/gaussian_neural_test/force_call_test_tflow.py:        for cores in range(1, 4):
    CuOPd_test/gaussian_neural_test/force_call_test.py:        for cores in range(1, 6):
    CuOPd_test/gaussian_neural_test/force_call_test.py:        for cores in range(1, 4):
    
  2. Log in to comment