- edited description
image-centered mode inside get_atomic_energy?
Issue #28
resolved
According to what we have discussed, the dividing line between atom-centered and image-centered mode is that in atom-centered mode the energy is written as the sum of atomic energies which is not the case in image-centered mode.
Therefore, I would expect that inside the function get_atomic_energy, we would have no image-centered stuff. I guess we can remove if image-centered here:
Comments (3)
-
reporter -
repo owner Yep, that should not every be called from image-centered mode. It may be worth leaving some kind of exception (probably RuntimeError) to alert the user if they tried to call the function in image-centered mode.
-
reporter - changed status to resolved
Implemented in the commit 4576e24.
- Log in to comment