Move train parameters to LossFunction
Issue #55
resolved
Many of the parameters in train could properly be moved to LossFunction. The user could then specify these criteria directly through the loss function, something like
calc = Amp( ... )
calc.model.lossfunction = LossFunction(force_coefficient=0.04)
or
calc.model.lossfunction.set('force_coefficient', 0.04)
We should also make this clear in the documentation when we update it.
Comments (3)
-
reporter -
-
reporter - changed status to resolved
Resolved with issue
#60. - Log in to comment
We will need to temporarily put in a keyword to
train
liketrain_forces=True
. Ultimately it should be a little different as we want this to work for other quantities.