convergence values

[Alireza Khorshidi]

In the current implementation of v0.5, it is not possible to fed in convergence values, I guess. This needs to be thought about.

[andrew_peterson]

What about this?

http://amp.readthedocs.io/en/latest/useamp.html#adjusting-convergence-parameters

[Alireza Khorshidi]

That works. Thanks!

[andrew_peterson]

The documentation doesn't match the current version of the code. I think we need to move the setting of the convergence parameters back into the LossFunction itself; that way the user can define their own criteria if they so choose.

Right now, I think it is going in through model.fit which the user does not usually use --- I can't see a way to put them in through calc.train.

[Alireza Khorshidi]

The documentation is updated. convergence parameters also now exist in the LossFunction method.

[andrew_peterson]

Can you supply the name of the commit where this was addressed? @akhorshi

[Alireza Khorshidi]

Sorry, by documentation I meant docstring :) Opened back this issue to discuss it in person.

[andrew_peterson]

I think it's all fixed up now. Note I expanded the description of the default parameters slightly in commit 4b4fa09.