_custom annotation may use hardcoded metadata.* names

[Ville Rantanen]

instance._custom("bundleName")="something"

is accepted and written in _command file. Is this something that should be returning an error? _command file already has that metadata, and now it will be written there twice.

[Kristian Ovaska]

It should be handled. Possibly all custom attributes should be under custom.bundleName and not metadata.

[Ville Rantanen]

agree

[Kristian Ovaska]

They are now in metadata.custom.KEY = VALUE.

[Ville Rantanen]

I think the customs should be written like this: metadata.custom_KEY=VALUE

in some (atleast bash) API's the keys are used as variable names, which do not allow for dots.

Also, it would be more in the fashion of the addition of array ports in anduril1, output._index_PORTNAME

[Ville Rantanen]

this edit breaks bash api, perhaps others

[Kristian Ovaska]

Good point. Now using metadata.custom_key=value.