Clarify AddBaseModules, simplify sorting modules

#46 Merged at 66dd3e5
Repository
takluyver
Branch
clarify-basemodules
Repository
anthony_tuininga
Branch
default
Author
  1. Thomas Kluyver
Reviewers
Description

Expanded a docstring to explain what I found out about ModuleFinder.AddBaseModules().

Simplified sorting a list of modules. This (the key parameter to sort) relies on Python 2.4 or above. The homepage still says we support Python 2.3 and up, but we only provide binaries for 2.6 and newer, and I wouldn't be surprised if we've already broken things on 2.3 - I've certainly never tested on that. The reason for this change is that sorting 2-tuples failed on Python 3 when two modules had identical names, which came up while I was fiddling around with fixes for issue #61.

Comments (3)

  1. Anthony Tuininga repo owner

    I don't think we need to worry about Python 2.3. I'll change the web site. Personally anything less than 2.6 isn't worth supporting -- and I certainly don't test with anything less than 2.6 (what shipped with the conservative CentOS 6). Any disagreement?

    1. Thomas Kluyver author

      Supporting 2.6 and up sounds like a good plan to me. I think a major selling point of cx_Freeze is that it's the only such tool with Python 3 support, so it makes sense to focus on that rather than on ancient versions of Python. 2.6 is a good starting point for compatibility, and I still have it around to test with if I need to.