Anonymous avatar Anonymous committed eabf07c

[svn] fixed button_to_function returning extra text, and added a test
for this function
resolves: #51

Comments (0)

Files changed (2)

tests/test_javascript.py

     def test_link_to_function_with_html_args(self):
         self.assertEqual("""<a href="/home" onclick="alert('Hello World!'); return false;">Greeting</a>""",
                link_to_function("Greeting", "alert('Hello World!')", href="/home"))
-    
-    
+
+    def test_button_to_function(self):
+        input_str = \
+            """<input onclick="alert('Hello World!'); " type="button" value="Greeting"></input>"""
+        self.assertEqual(input_str,
+                         button_to_function("Greeting", "alert('Hello World!')"))
+
 if __name__ == '__main__':
     suite = [unittest.makeSuite(TestJavascriptHelper)]
     for testsuite in suite:
-        unittest.TextTestRunner(verbosity=1).run(testsuite)
+        unittest.TextTestRunner(verbosity=1).run(testsuite)

webhelpers/rails/javascript.py

     """
     options = dict(type_="button", value=name, onclick="%s; " % function)
     options.update(html_options)
-    return content_tag("input", name, **options)
+    return content_tag("input", "", **options)
 
 def escape_javascript(javascript):
     """
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.