Converter Refactoring

Ryan Schimpel

The relevant converter code has been pulled out of symphony.common.converters.Activators and put into a newly created facade, Symphony__CommonConvertersFacade (specified with an .xcore model). The graph utilities have also been refactored and put into their own facade, Symphony__CommonConvertersGraphsFacade (specified with another .xcore model).

The convert(ISelection, Class<?>) method has, as requested been pulled out of Symphony__CommonConvertersFacade, and put into the symphony.common.converters.ui plugin; in particular, that method has been added to the new Symphony__CommonConvertersUIFacade class (which too is specified by an .xcore model.)

All changes have been tested and the converter code still works correctly. As such, these updates have been pushed to the main Git repo.

2015-10-28T20:58:02+00:00

Comments (2)

Ryan Schimpel
The relevant converter code has been pulled out of symphony.common.converters.Activators and put into a newly created facade, Symphony__CommonConvertersFacade (specified with an .xcore model). The graph utilities have also been refactored and put into their own facade, Symphony__CommonConvertersGraphsFacade (specified with another .xcore model).

The convert(ISelection, Class<?>) method has, as requested been pulled out of Symphony__CommonConvertersFacade, and put into the symphony.common.converters.ui plugin; in particular, that method has been added to the new Symphony__CommonConvertersUIFacade class (which too is specified by an .xcore model.)

All changes have been tested and the converter code still works correctly. As such, these updates have been pushed to the main Git repo.
- 2015-10-28T20:58:02+00:00
Ryan Schimpel
- changed status to resolved
- 2015-10-28T20:58:13+00:00
Log in to comment