Benjamin Peterson avatar Benjamin Peterson committed 8b384de

generally, sockets should be closed after they're used

Comments (0)

Files changed (1)

Lib/socketserver.py

         else:
             # Child process.
             # This must never return, hence os._exit()!
-            self.socket.close()
             try:
                 self.finish_request(request, client_address)
+                self.socket.close()
                 os._exit(0)
             except:
                 try:
                     self.handle_error(request, client_address)
+                    self.socket.close()
                 finally:
                     os._exit(1)
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.