- edited description
Key shift affects drums.
Issue #64
resolved
Adjusting the key shift erroneously changes the drum bank, causing the percussion to get really weird depending on what key you’ve moved into. What should be a woodblock, for example, might become a cuica. This is solved simply:
var key_shift:int = self.key_shift
if channel.drum_track:
key_shift = 0
var key_number:int = note + key_shift
Applied to both _process_track_event_note_on
and _process_track_event_note_off
in MidiPlayer.gd
.
Comments (3)
-
reporter -
repo owner Thanks for report. I completely forget that implemented key_shift. lol
I fixed it at
a44ba91
-
repo owner - changed status to resolved
- Log in to comment